Skip to content

Added substrate network #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added substrate network #236

wants to merge 2 commits into from

Conversation

kekonen
Copy link
Contributor

@kekonen kekonen commented Sep 5, 2022

Motivation

We want a clear distinction between EVM and others networks (ie Substrate).

Solution

Added an enum into domain, which specifies whether the network is EVM (with info inside) or Substrate (empty)

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package
  • Ran PR in local/dev/staging

@kekonen kekonen requested a review from luketchang September 5, 2022 15:06
@kekonen kekonen mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketchang luketchang Awaiting requested review from luketchang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kekonen